D10042: feat: parse EDID on the backend side

[Roman Gilg]

romangg added a comment.


  The idea to parse on the backend side is sound. Can you paste the output you get in a Wayland session? For me it shows the XWayland EDID of the outputs.

INLINE COMMENTS

> waylandbackend.cpp:81
> +    auto device = output->outputDevice();
> +    auto edid = new Edid::Private;
> +    edid->vendorName = device->manufacturer();

Let the backend populate the Private here is unusual, or is it not? On the other side it makes sense. Let the consumer only access the public interface and the backend access the private one. I don't know what's the commonly used approach to that in Qt dev. Out of interest you can say? In any case we can leave it like that for now.

> waylandbackend.cpp:90
> +    edid->checksum = QString::fromLatin1(device->uuid());
> +    edid->valid = true;
> +

A WaylandOutput::edid() function should be put in the WaylandOutput class.

REPOSITORY
  R110 KScreen Library

REVISION DETAIL
  https://phabricator.kde.org/D10042

To: dvratil, sebas, #plasma, romangg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200308/8b01c642/attachment-0001.html>