D27895: use content_type as fallback in appchooser dialog

Harald Sitter noreply at phabricator.kde.org
Fri Mar 6 12:47:11 GMT 2020


sitter created this revision.
sitter added a reviewer: jgrulich.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  when there is no filename (e.g. for magnet uris) the dialog would show
  %1(I18NARGUMENTMISSING). very awkward. instead fall back to the content
  type so it'd say something like 'Select an application to open
  x-scheme-handler/magnet'

TEST PLAN
  warning is gone from dialog when trying to open magnet uris without suitable client

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

BRANCH
  fix-i18n

REVISION DETAIL
  https://phabricator.kde.org/D27895

AFFECTED FILES
  src/appchooser.cpp

To: sitter, jgrulich
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200306/e6b6f169/attachment-0001.html>


More information about the Plasma-devel mailing list