D27892: [RFC] Don't draw shadows on quick tiled or maximized edges

David Redondo noreply at phabricator.kde.org
Fri Mar 6 12:05:03 GMT 2020


davidre created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REVISION SUMMARY
  For a quick tiled window we currently don't draw a border on the edges it is
  tiled to but we still draw a shadow. In a one screen case this is cannot be
  noticed because the shadows are outside of the screen. In a multi screen
  environment however this causes quick tiled windows to cast shadow across the
  screen border that they are tiled to. If one has multiple of such tiled windows
  it darkens the neighboring area of the bordering screen significantly.
  This patch uses the same criteria whether to draw a shadow on a side as is used
  to determine if a border should be drawn. Each decoration instance now has its
  own shadow instance. The actual shadow texture is still only generated once and
  shared, the partial shadows are partial copies of it.

REPOSITORY
  R31 Breeze

BRANCH
  shadow (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27892

AFFECTED FILES
  kdecoration/CMakeLists.txt
  kdecoration/breezedecoration.cpp
  kdecoration/breezedecorationshadow.cpp
  kdecoration/breezedecorationshadow.h

To: davidre
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200306/d6b7e3c0/attachment.html>


More information about the Plasma-devel mailing list