D27885: [gmenu-dbusmenu-proxy] Fix radio button state detection

Kai Uwe Broulik noreply at phabricator.kde.org
Fri Mar 6 09:15:06 GMT 2020


broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Instead of comparing the state of the action to the action name, compare it to the argument the action will invoke it with.
  In contrast to checkboxes, which are independent actions with a boolean state, radio menu items all refer to the same action (e.g. "Zoom") and then pass the new state ("zoom-100", "zoom-200", etc) as target when invoking the action.
  
  CCBUG: 418385

TEST PLAN
  5.18
  
  - View modes in mediainfo-gui is now correctly shown in the menu
  - Zoom and view modes in Inkscape and Gimp are correctly indicated now
  - LibreOffice is still quite borked overall (but that is also without this patch)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27885

AFFECTED FILES
  gmenu-dbusmenu-proxy/window.cpp

To: broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200306/72e758ca/attachment.html>


More information about the Plasma-devel mailing list