D27884: [gmenu-dbusmenu-proxy] Pass action "target" in invocation

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  According to documentation [1] a menu item has a `target` attribute, which is "the parameter to pass when activating the action". Furthermore, the action "Activate" method specifies "If the action activation requires a parameter then this parameter must be given in the second parameter (av).".
  Also implements a TODO in the code.
  
  [1] https://wiki.gnome.org/Projects/GLib/GApplication/DBusAPI
  
  CCBUG: 418385

TEST PLAN
  5.18
  
  - Can change view modes in mediainfo-gui now
  - Can still change view modes in LibreOffice, Inkscape, Gimp
  - Can still toggle checkboxes in LibreOffice, Inkscape, Gimp, Shotwell
  - Can still invoke normal menu items (such as "Open") in LibreOffice, inkscape, Gimp, Shotwell

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27884

AFFECTED FILES
  gmenu-dbusmenu-proxy/actions.cpp
  gmenu-dbusmenu-proxy/actions.h
  gmenu-dbusmenu-proxy/window.cpp
  gmenu-dbusmenu-proxy/window.h

To: broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200306/758080de/attachment.html>