D27847: [applet/taskmanager] Remove the launcher items' tooltip icons
Nathaniel Graham
noreply at phabricator.kde.org
Wed Mar 4 21:58:21 GMT 2020
ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.
REVISION SUMMARY
As discussed in T12778 <https://phabricator.kde.org/T12778>, the icon can never be in a correct state: either it's
redundant with the icon you're hovering over that made the tooltip appear, or
else it's different from the icon you're hovering over, which is inconsistent.
Furthermore, some instances of the tooltip have icons and others do not,
heightening the inconsistency.
Since either case is undesirable, let's just remove the icon from the tooltip
entirely. This reduces the visual noise in the tooltip and solves the entire
class of bugs automatically.
TEST PLAN
F8150018: App launcher.png <https://phabricator.kde.org/F8150018>
F8150021: Icon-less tooltips.webm <https://phabricator.kde.org/F8150021>
REPOSITORY
R119 Plasma Desktop
BRANCH
remove-tooltip-icon (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D27847
AFFECTED FILES
applets/taskmanager/package/contents/ui/ToolTipInstance.qml
To: ngraham, #vdg, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200304/6c65c01a/attachment-0001.html>
More information about the Plasma-devel
mailing list