D27347: Only link to Qt5WebChannel if Qt5WebEngineWidgets available

[Fabian Vogt]

fvogt added a comment.


  Currently `processui/scripting.cpp` has this:
  
    #if HAVE_QTWEBENGINEWIDGETS
    #include <QWebChannel>
    ...
    #endif
  
  So `Qt5WebEngineWidgets` without `Qt5WebChannel` will fail to build and `Qt5WebChannel` without `Qt5WebEngineWidgets` leads to scripting support getting disabled.
  My question is what the right way to handle this is. List both as optional dependencies and use `#if HAVE_QTWEBENGINEWIDGETS && HAVE_QTWEBCHANNEL` instead or raise a cmake error out in the former case?

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D27347

To: fvogt, #plasma, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200302/29095ec8/attachment.html>