D27764: Update L2TP to NetworkManager-l2tp 1.8.0 features

[Douglas Kosovic]

dkosovic created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added a reviewer: jgrulich.
dkosovic requested review of this revision.

REVISION SUMMARY
  - Update to NetworkManager-l2tp 1.8.0 features which include:
    - NetworkManager-l2tp 1.8.0 user certificate support.
    - Machine certificate support.
    - Rename Gateway ID to Remote ID.
    - Phase 1 & Phase 2 Lifetime TimeEdits.
    - Use IP Compression CheckBox.
    - Disable PFS CheckBox.
  - Synchronize nm-l2tp-service.h with NetworkManager-l2tp 1.8.0's nm-service-defines.h.
  - Base new user certificate UI on openvpn UI.
  - Delete l2tpauth.ui and replace with programmatically generated  l2tpauthwidget.
  - Add user and machine private key / certificate password support to l2tpauthwidget.
  - Detect if libreswan or strongswan is being used and change UI based on which one is detected, e.g. disable "Disable PFS" check box with strongswan, Phase 1 & Phase 2 Lifetime show default strongswan and libreswan values when unchecked.
  - Disable IPSec settings button if libreswan or strongswan not detected.
  - Remove visibility of PPP Authentication group box if user certificate authentication is selected.
  - Support loading *SWAN Base64 encoded PSK, but for backwards compatibility use unencoded for saving settings.
  - For backwards compatibility with older NetworkManager-l2tp use `NM_L2TP_KEY_IPSEC_GATEWAY_ID` instead of `NM_L2TP_KEY_IPSEC_REMOTE_ID` for saving connection settings.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27764

AFFECTED FILES
  vpn/l2tp/CMakeLists.txt
  vpn/l2tp/l2tp.cpp
  vpn/l2tp/l2tp.ui
  vpn/l2tp/l2tpauth.cpp
  vpn/l2tp/l2tpauth.h
  vpn/l2tp/l2tpauth.ui
  vpn/l2tp/l2tpipsec.ui
  vpn/l2tp/l2tpipsecwidget.cpp
  vpn/l2tp/l2tpipsecwidget.h
  vpn/l2tp/l2tppppwidget.cpp
  vpn/l2tp/l2tppppwidget.h
  vpn/l2tp/l2tpwidget.cpp
  vpn/l2tp/l2tpwidget.h
  vpn/l2tp/nm-l2tp-service.h

To: dkosovic, jgrulich
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200301/9cb466d6/attachment.html>