D29847: Fixes compile problem for freebsd because of missing crypt.h
Ömer Fadıl Usta
noreply at phabricator.kde.org
Sun Jun 7 10:06:32 BST 2020
usta added inline comments.
INLINE COMMENTS
> tcberner wrote in user.cpp:23
> wouldn't it be a bit more portable to check for the header file in cmake? (OpenBSD also has the same issue, I would assume from [1])
>
> [1] https://www.freebsd.org/cgi/man.cgi?query=crypt&apropos=0&sektion=3&manpath=OpenBSD+6.7&arch=default&format=html
I never think about openbsd , yes you are right about it. So how about if we use something like :
#if !defined(Q_OS_UNIX) && !defined(Q_OS_BSD4) && !defined(Q_OS_FREEBSD) && !defined(Q_OS_FREEBSD) && !defined(Q_OS_NETBSD) && !defined(Q_OS_OPENBSD)
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D29847
To: usta, #plasma, bcooksley, ngraham, adridg, #freebsd
Cc: tcberner, adridg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200607/5d80102a/attachment.htm>
More information about the Plasma-devel
mailing list