D27074: [Applet]Add port check

George Vogiatzis noreply at phabricator.kde.org
Fri Jan 31 17:27:34 GMT 2020


gvgeo added a comment.


  In D27074#604235 <https://phabricator.kde.org/D27074#604235>, @ngraham wrote:
  
  > Maybe only show the description when there's more than one input or output device? I thought the lack of a description for the single-device use case was a feature! :) It looks so nice and clean: F8062861: popup, one device.png <https://phabricator.kde.org/F8062861>
  
  
  II don't see the problem, in this picture. I don't even know if it is before of after this patch.
  It looks fine, both devices show the port.
  
  This should not change anything. It is a bug fix.
  There are 2 descriptions, `Device description` and `Port description`. We prefer to show the Port description.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D27074

To: gvgeo, #plasma, drosca, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200131/7b994ad2/attachment-0001.html>


More information about the Plasma-devel mailing list