D26729: do not disable getifaddrs use because of sa_len availablility

Johnny Jazeix noreply at phabricator.kde.org
Fri Jan 31 15:50:24 GMT 2020


jjazeix added inline comments.

INLINE COMMENTS

> nic.cpp:137
> +#ifdef HAVE_STRUCT_SOCKADDR_SA_LEN
> +    return getnameinfo(addr, ifa->ifa_addr->sa_len, buf, 127, 0, 0, NI_NUMERICHOST);
> +#else

buf is not defined in this conditional and causes a build fail on freebsd: https://build.kde.org/view/Failing/job/Plasma/job/kinfocenter/job/kf5-qt5%20FreeBSDQt5.13/lastFailedBuild/

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D26729

To: sitter, ngraham
Cc: jjazeix, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200131/46b638a3/attachment-0001.html>


More information about the Plasma-devel mailing list