D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

Alexander Lohnau noreply at phabricator.kde.org
Fri Jan 31 15:09:59 GMT 2020


alex created this revision.
alex added reviewers: kossebau, vhanda.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alex requested review of this revision.

REVISION SUMMARY
  The two foreach occurences are refactored and the signals in the runner/kcm now use the C++ 11 for loop.
  Additonally the duplicate call of the load method has been removed and smaller improvements have been made.

TEST PLAN
  Compile time check for signals, trying out the runner and editing the config.

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27070

AFFECTED FILES
  runners/spellchecker/spellcheck.cpp
  runners/spellchecker/spellcheck_config.cpp

To: alex, kossebau, vhanda
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200131/a4b5024c/attachment.html>


More information about the Plasma-devel mailing list