D27061: replace samba module with data that works

[Harald Sitter]

sitter created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  ... and doesn't require lots of maintenance!
  this targets 5.18 but is kind of unfortunate because it needs a bunch of
  new strings as no existing strings provide what is needed here.
  
  the previous module was super broken in various ways.
  in the interest of maintainability I've thrown everything out and replaced
  it with 2 core features which require only modeling code on the KInfoCenter
  end and provide actually (possibly) useful functionality to the design
  personas of plasma.
  
  there is now a single page which contains two table views:
  
  a) Exports: this is a simple table of shares "exported" from the host. the
  
    data for this comes from KSambaShare in KIOCore. this is the same API
    used by dolphin to create new shares, so the data will be consistent
    and the API needs maintaining anyway
  
  b) Imports: simple table of shares "imported" (i.e. mounted) onto the host.
  
    the data for this comes from solid
  
  both are backed by models, with an eye towards a future port to qml (out of
  scope since I want this fixed for 5.18)
  
  all previous functionality was removed, in part because it was doing CLI
  parsing, some of the parsing was broken, some of the CLI tools couldn't
  even run as !root, log parsing could use incorrect paths on existing users,
  log parsing has nothing to parse with samba defaults, log parsing didn't
  implement per-host log file support (current default in samba), log parsing
  didn't correctly implement per-user-config-log-file support.
  in short: there was not a single feature that worked properly.
  
  BUG: 411433
  BUG: 374141
  BUG: 325951

TEST PLAN
  exports
  =======
  
  - nothing when nothing is exported
  - changing exports via dolphin is immediately reflected in the kcm
  - export data is valid
  
  imports
  =======
  
  - nothing when nothing is mounted
  - (un)mounting a cifs updates the view immediately
  - data is valid

REPOSITORY
  R102 KInfoCenter

BRANCH
  smb

REVISION DETAIL
  https://phabricator.kde.org/D27061

AFFECTED FILES
  LICENSES/GPL-2.0-only.txt
  LICENSES/GPL-2.0-or-later.txt
  LICENSES/GPL-3.0-only.txt
  LICENSES/LicenseRef-KDE-Accepted-GPL.txt
  LICENSES/MIT.txt
  Modules/samba/CMakeLists.txt
  Modules/samba/autotests/CMakeLists.txt
  Modules/samba/autotests/ksambasharemodeltest.cpp
  Modules/samba/autotests/smbmountmodeltest.cpp
  Modules/samba/kcmsambaimports.cpp
  Modules/samba/kcmsambaimports.h
  Modules/samba/kcmsambalog.cpp
  Modules/samba/kcmsambalog.h
  Modules/samba/kcmsambastatistics.cpp
  Modules/samba/kcmsambastatistics.h
  Modules/samba/ksambasharemodel.cpp
  Modules/samba/ksambasharemodel.h
  Modules/samba/ksmbstatus.cpp
  Modules/samba/ksmbstatus.h
  Modules/samba/main.cpp
  Modules/samba/smbmountmodel.cpp
  Modules/samba/smbmountmodel.h

To: sitter
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200131/076d6561/attachment.html>