D27055: [kcms/cursortheme] Don't skip everything because of lack of XFixes

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> kcmcursortheme.cpp:301
>  
> -    // Qt cursors
> -    names << "left_ptr"       << "up_arrow"      << "cross"      << "wait"
> -          << "left_ptr_watch" << "ibeam"         << "size_ver"   << "size_hor"
> -          << "size_bdiag"     << "size_fdiag"    << "size_all"   << "split_v"
> -          << "split_h"        << "pointing_hand" << "openhand"
> -          << "closedhand"     << "forbidden"     << "whats_this" << "copy" << "move" << "link";
> -
> -    // X core cursors
> -    names << "X_cursor"            << "right_ptr"           << "hand1"
> -          << "hand2"               << "watch"               << "xterm"
> -          << "crosshair"           << "left_ptr_watch"      << "center_ptr"
> -          << "sb_h_double_arrow"   << "sb_v_double_arrow"   << "fleur"
> -          << "top_left_corner"     << "top_side"            << "top_right_corner"
> -          << "right_side"          << "bottom_right_corner" << "bottom_side"
> -          << "bottom_left_corner"  << "left_side"           << "question_arrow"
> -          << "pirate";
> -
> -    foreach (const QString &name, names) {
> -        XFixesChangeCursorByName(QX11Info::display(), theme->loadCursor(name, size), QFile::encodeName(name));
> +    if (CursorTheme::haveXfixes()) {
> +        // Qt cursors

Move this above `QStringList names;`

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27055

To: davidedmundson, #plasma, broulik
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200131/dee42a40/attachment.html>