D27054: Syncronise environment to user systemd session

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> updatelaunchenvjob.cpp:104
> +                                                                    QStringLiteral("/org/freedesktop/systemd1"),
> +                                                                    QStringLiteral("org.freedesktop.systemd1.Manager"),QStringLiteral("SetEnvironment"));
> +    const QString updateString = d->varName + "=" + d->value;

Coding style

> updatelaunchenvjob.cpp:105
> +                                                                    QStringLiteral("org.freedesktop.systemd1.Manager"),QStringLiteral("SetEnvironment"));
> +    const QString updateString = d->varName + "=" + d->value;
> +    systemdActivationMsg.setArguments({QVariant(QStringList{updateString})});

Does this need some form of escaping?

> updatelaunchenvjob.cpp:108
> +
> +    auto systemdActivationReply = QDBusConnection::sessionBus().asyncCall(dbusActivationMsg);
> +    d->monitorReply(systemdActivationReply);

You probably want to send `systemdActivationMsg`

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27054

To: davidedmundson, #plasma
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200131/756ecb98/attachment-0001.html>