D27037: [Notifications] Fixup setSourceModel

Kai Uwe Broulik noreply at phabricator.kde.org
Thu Jan 30 14:58:44 GMT 2020


broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Qt says to do a proper model reset in this method.
  I also noticed something funky going on with the `LimitedRowCountProxyModel` not showing any data which went away with this.

TEST PLAN
  5.18

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27037

AFFECTED FILES
  libnotificationmanager/limitedrowcountproxymodel.cpp
  libnotificationmanager/notificationgroupcollapsingproxymodel.cpp

To: broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200130/0da787f6/attachment-0001.html>


More information about the Plasma-devel mailing list