D27029: Remove header top margin from private ScrollView
Arjen Hiemstra
noreply at phabricator.kde.org
Thu Jan 30 12:13:24 GMT 2020
ahiemstra created this revision.
ahiemstra added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.
REVISION SUMMARY
With the scrollbars taking up actual width, the top margin of the vertical
scrollbar being set to the list header looks really awkward and buggy. This
removes the top margin, making the scrollbar take the entire flickable's
height. This change also applies to overlay scrollbars as I consider the
margin behaviour to be incorrect even for those, as the top margin will
change based on the header height, which causes the scrollbar to resize
when the header shrinks.
REPOSITORY
R169 Kirigami
BRANCH
scrollbar_topmargin
REVISION DETAIL
https://phabricator.kde.org/D27029
AFFECTED FILES
src/controls/templates/private/ScrollView.qml
To: ahiemstra, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200130/955a62f5/attachment.html>
More information about the Plasma-devel
mailing list