D27019: Solid-device-automounter/kcm: Hide ignored Solid::StorageAccess

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> DeviceModel.cpp:119
> +        const Solid::StorageAccess *access = dev.as<Solid::StorageAccess>();
> +        if (access == nullptr || !access->isIgnored()) {
> +            beginInsertRows(index(0, 0), m_attached.size(), m_attached.size());

Do we want to add items that are *not* a `StorageAccess`?
Shouldn't this be more like

  if (access && !access->isIgnored())`

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27019

To: meven, #plasma, broulik, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200130/07cae194/attachment.html>