D26985: [Panel Shadows] Un-constify QWindow parameters

Vlad Zahorodnii noreply at phabricator.kde.org
Wed Jan 29 11:54:34 GMT 2020


zzag created this revision.
zzag added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
zzag requested review of this revision.

REVISION SUMMARY
  It doesn't make sense to pass const `QWindow`s to `PanelShadows` because
  a `KWindowShadow` needs a mutable `QWindow` object.

TEST PLAN
  const_cast in PanelShadows::Private::updateShadow is gone \o/

REPOSITORY
  R120 Plasma Workspace

BRANCH
  pass-mutable-window-to-panel-shadows

REVISION DETAIL
  https://phabricator.kde.org/D26985

AFFECTED FILES
  shell/panelshadows.cpp
  shell/panelshadows_p.h

To: zzag, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200129/964855df/attachment-0001.html>


More information about the Plasma-devel mailing list