D26977: Fix setting of initial passwords for new users

David Edmundson noreply at phabricator.kde.org
Wed Jan 29 01:57:01 GMT 2020


davidedmundson added a comment.


  Aha, found what changed it:
  
  2471fa7d252de904b305dac77171fa300d66c05d <https://phabricator.kde.org/R128:2471fa7d252de904b305dac77171fa300d66c05d>
  
  - if (!roles.contains(Username) || !roles.contains(RealName) || !roles.contains(Administrator)) {
  
  +    if (!roles.contains(Username) || !roles.contains(RealName)) {
  
  because administrator is set last, it was previously effectively doing what this patch is doing
  
  *but* on closer inspection what this is doing should work regardless, any setData that wasn't needed for creating an account was buffered, any new stuff in theory is on the same row, that row now has an entry in m_users so it should make the call

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D26977

To: davidedmundson, #plasma, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200129/4acb7fde/attachment-0001.html>


More information about the Plasma-devel mailing list