D26972: Work around an issue with changing the wallpaper's filetype

Nathaniel Graham noreply at phabricator.kde.org
Tue Jan 28 19:03:57 GMT 2020


ngraham created this revision.
ngraham added reviewers: davidedmundson, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Because of the issue described in T12611 <https://phabricator.kde.org/T12611>, changing the filetype of the Next wallpaper is
  problematic and will cause a black screen on upgrade.
  
  This terrible horrible patch works around the issue by using the .png filename extension
  even though this is not accurate. That way, the file names are the same as the old
  versions of the Next wallpaper and will be loaded correctly. Using the wrong filename
  extension does not actually cause any problems, it's just inaccurate. a `README` file is
  placed next to the images to explain this.
  
  I'm sorry.
  
  Long-term, we should investigate T12611 <https://phabricator.kde.org/T12611>.

TEST PLAN
  Have previous Next wallpaper (Ice Cold) installed
  Replace it on disk with Volna in original JPEG form
  restart plasmashell -> black screen
  
  Try the above again with this patch
  restart plasmashell -> new wallpaper visible

REPOSITORY
  R31 Breeze

BRANCH
  fix-wallpaper-type-changing (branched from Plasma/5.18)

REVISION DETAIL
  https://phabricator.kde.org/D26972

AFFECTED FILES
  wallpapers/Next/contents/images/1024x768.jpg
  wallpapers/Next/contents/images/1024x768.png
  wallpapers/Next/contents/images/1280x1024.jpg
  wallpapers/Next/contents/images/1280x1024.png
  wallpapers/Next/contents/images/1280x800.jpg
  wallpapers/Next/contents/images/1280x800.png
  wallpapers/Next/contents/images/1366x768.jpg
  wallpapers/Next/contents/images/1366x768.png
  wallpapers/Next/contents/images/1440x900.jpg
  wallpapers/Next/contents/images/1440x900.png
  wallpapers/Next/contents/images/1600x1200.jpg
  wallpapers/Next/contents/images/1600x1200.png
  wallpapers/Next/contents/images/1680x1050.jpg
  wallpapers/Next/contents/images/1680x1050.png
  wallpapers/Next/contents/images/1920x1080.jpg
  wallpapers/Next/contents/images/1920x1080.png
  wallpapers/Next/contents/images/1920x1200.jpg
  wallpapers/Next/contents/images/1920x1200.png
  wallpapers/Next/contents/images/2560x1440.jpg
  wallpapers/Next/contents/images/2560x1440.png
  wallpapers/Next/contents/images/2560x1600.jpg
  wallpapers/Next/contents/images/2560x1600.png
  wallpapers/Next/contents/images/3200x1800.jpg
  wallpapers/Next/contents/images/3200x1800.png
  wallpapers/Next/contents/images/3200x2000.jpg
  wallpapers/Next/contents/images/3200x2000.png
  wallpapers/Next/contents/images/3840x2160.jpg
  wallpapers/Next/contents/images/3840x2160.png
  wallpapers/Next/contents/images/5120x2880.jpg
  wallpapers/Next/contents/images/5120x2880.png
  wallpapers/Next/contents/images/README

To: ngraham, davidedmundson, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200128/7b14c5d0/attachment.html>


More information about the Plasma-devel mailing list