D26912: Use Qt5 signal syntax, format files, optimizations

Laurent Montel noreply at phabricator.kde.org
Tue Jan 28 18:57:19 GMT 2020


mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> autostart.cpp:64
> +    connect(widget->btnProperties, &QPushButton::clicked,
> +            this, static_cast<void (Autostart::*)()>((&Autostart::slotEditCMD)));
> +    connect(widget->listCMD, &QTreeWidget::itemDoubleClicked,

why double ( ?

> autostart.cpp:66
> +    connect(widget->listCMD, &QTreeWidget::itemDoubleClicked,
> +            this, static_cast<void (Autostart::*)(QTreeWidgetItem *)>((&Autostart::slotEditCMD)));
>  

same

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26912

To: alex, mlaurent, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200128/e4ea2116/attachment-0001.html>


More information about the Plasma-devel mailing list