D26895: Introduce an Info Center mode

David Edmundson noreply at phabricator.kde.org
Tue Jan 28 13:01:41 GMT 2020


davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> SidebarMode.cpp:589
>  
> -    if (introPageVisible) {
> -        d->activeCategoryRow = -1;
> -        emit activeCategoryRowChanged();
> -        d->activeSubCategoryRow = -1;
> -        emit activeSubCategoryRowChanged();
> -        d->placeHolderWidget->show();
> -        d->moduleView->hide();
> -    } else {
> +    // TODO: eventually make the intro page of SystemSettings a KCM as well?
> +    if (homeItem()) {

Yes! that would be a nicer design

REPOSITORY
  R124 System Settings

BRANCH
  mart/kinfoCenterMode

REVISION DETAIL
  https://phabricator.kde.org/D26895

To: mart, #plasma, davidedmundson
Cc: meven, davidedmundson, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200128/fcb42b68/attachment.html>


More information about the Plasma-devel mailing list