D26806: [Applets/Power Manager] Update layout based on T10470

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> BatteryItem.qml:48
> +        spacing: units.smallSpacing
> +        width: leftColumnWidth + spacing + rightColumnWidth
>  

width used inside a layout

> BatteryItem.qml:57
>                  height: implicitHeight
> +                width: modelData.label ? detailsLayout.leftColumnWidth : detailsLayout.rightColumnWidth
> +                wrapMode: Text.NoWrap

width/height used inside a layout

> BatteryItem.qml:83
> +                id: batteryIcon
> +                width: units.iconSizes.smallMedium
> +                height: width

here

> PopupDialog.qml:147
> +                    id: batteryList
> +                    height: childrenRect.height
> +                    implicitHeight: height

and here

> PowerManagementItem.qml:34
> +    MouseArea {
> +        width: childrenRect.width
> +        height: childrenRect.height

and here

and you shouldn't need to be using chidrenRect.width 
when your child has

  anchors.fill: parent

that's a loop

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26806

To: gvgeo, #plasma, #vdg, davidedmundson, manueljlin
Cc: broulik, ngraham, manueljlin, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200124/90f55719/attachment-0001.html>