D26797: KCM/Component Refactor UI to a single list of combobox

[Méven Car]

meven added a comment.


  In D26797#599747 <https://phabricator.kde.org/D26797#599747>, @filipf wrote:
  
  > A lot cleaner and straightforward now, good job. I was wondering though what it would look like if we made all the comoboboxes have equal width (if possible).
  
  
  I can make that happen, at some point they expanded to the right which wasn't ideal.

INLINE COMMENTS

> broulik wrote in componentchooser.cpp:93
> Check if `loadedConfigWidget` is null

I'd rather have a Q_ASSERT : this isn't supposed to happen

REPOSITORY
  R119 Plasma Desktop

BRANCH
  new-component-chooser

REVISION DETAIL
  https://phabricator.kde.org/D26797

To: meven, #plasma, #vdg, ngraham, ervin
Cc: filipf, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200123/d279d2b0/attachment.html>