D26825: Bind gtk-enable-animations setting to global animation speed slider

[Mikhail Zolotukhin]

gikari requested changes to this revision.
gikari added a comment.
This revision now requires changes to proceed.


  Seems like dconf does not convert !!string!! to !!boolean!!.
  
    (process:24285): GLib-GIO-CRITICAL **: 17:51:47.492: g_settings_set_value: key 'enable-animations' in 'org.gnome.desktop.interface' expects type 'b', but a GVariant of type 's' was given
  
  The method `setGtk3ConfigValueDconf` should be parameterized with the argument `paramValue` to be !!boolean!!. Something like this might work:
  
    void ConfigEditor::setGtk3ConfigValueDconf(const QString &paramName, bool paramValue, const QString &category)
    {
        g_autoptr(GSettings) gsettings = g_settings_new(category.toUtf8().constData());
        g_settings_set_boolean(gsettings, paramName.toUtf8().constData(), paramValue);
    }

INLINE COMMENTS

> configvalueprovider.h:57
>      KSharedConfigPtr kwinConfig;
> +    KSharedConfigPtr ownConfig;
>  };

It's not clear what `ownConfig` config is. `GtkConfig` does not have its own config (and even if it has, it is a bit strange to watch their own config in this context). If I understand correctly it is the `kdeglobals`. It would be nice to name it `kdeglobalsConfig` or `globalsConfig`

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D26825

To: broulik, #plasma, gikari
Cc: ngraham, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200122/0415cfa1/attachment.html>