D26825: Bind gtk-enable-animations setting to global animation speed slider

Kai Uwe Broulik noreply at phabricator.kde.org
Wed Jan 22 12:21:38 GMT 2020


broulik added inline comments.

INLINE COMMENTS

> davidedmundson wrote in configvalueprovider.cpp:146
> You don't need this.
> 
> KConfigWatcher does it automagically on change.
> 
> I did that because I wanted a way for N connections to only reparse the file once. It also means you can use the config watcher with no signal handling, just install and you get the correct values on the next read. Amazing.
> 
> My fault for not having enough docs

I know, I just kept it consistent with the other code. Let's clean up this everywhere else above separately?

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D26825

To: broulik, #plasma, gikari
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200122/6e2535f2/attachment.html>


More information about the Plasma-devel mailing list