D26806: [Applets/Power Manager] Update layout based on T10470
George Vogiatzis
noreply at phabricator.kde.org
Tue Jan 21 13:14:47 GMT 2020
gvgeo created this revision.
gvgeo added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gvgeo requested review of this revision.
REVISION SUMMARY
Icons were decreased in sized and placed in row with their labels.
'Enable power management' was moved to bottom. Suppression messages
kept on top, but now mirror in the checkbox's tooltip too.
The complete main view can scroll now (only batteries
could scroll).
For the 'Enable power management' checkbox, fixed tooltip and switch
area (tooltip was only on text, and switch was on full width).
Battery stats kept bellow. There are multiple batteries (laptop main
battery, keyboard, mouse etc.), and include many stats (eg. charge,
health, charge time).
Issues:
Tab does not cycle though when on desktop (shift-tab works).
Needs systemtray or theme update too. Otherwise suppression messages
look weird.
Issues with sliders:
Wheel need 33,3 complete rotations to reach from minimum to maximum.
Do not scale.
Leave 1 pixel On at the left, leaving the impression that can lower
brightness more.
REPOSITORY
R120 Plasma Workspace
BRANCH
b3 (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D26806
AFFECTED FILES
applets/batterymonitor/package/contents/ui/BatteryItem.qml
applets/batterymonitor/package/contents/ui/BrightnessItem.qml
applets/batterymonitor/package/contents/ui/InhibitionHint.qml
applets/batterymonitor/package/contents/ui/PopupDialog.qml
applets/batterymonitor/package/contents/ui/PowerManagementItem.qml
applets/batterymonitor/package/contents/ui/batterymonitor.qml
To: gvgeo, #plasma, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200121/34105aad/attachment.html>
More information about the Plasma-devel
mailing list