D26797: KCM/Component Refactor UI to a single list of combobox

[Kevin Ottens]

ervin added inline comments.

INLINE COMMENTS

> meven wrote in componentchooser.cpp:98
> I kept it as the compiler might be able to do some optimization in the loop when val is true line 105.
> It may skip the `plugin->hasChanged();` calls in that case, but I am not sure it gcc is clever enough to accomplish this.

I don't think you'd find a compiler doing this, there's nothing ensuring that hasChanged doesn't modify some mutable variable (cache management or such). I don't think one can safely spare the call in the general case.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26797

To: meven, #plasma, #vdg, ngraham, ervin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200121/0e644614/attachment.html>