D26796: [Notifications] When there is only a reply action, show reply field right away
Kai Uwe Broulik
noreply at phabricator.kde.org
Mon Jan 20 17:06:03 GMT 2020
broulik created this revision.
broulik added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
Makes it more obvious that there is an inline reply rather than having a "Reply" button where the user must guess what it'll do.
TEST PLAN
Since quick reply isn't really used anywhere yet I would like to have this in 5.18
- Sent notification with only inline-reply action, got text field right away, clicking it focused the text field properly
- Sent notification with inline-reply + another action, got two buttons, inline-reply button revealed text field and focused it properly autoamtically
- Verified that "default" action did not count as an action in this calculation
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D26796
AFFECTED FILES
applets/notifications/package/contents/ui/NotificationItem.qml
To: broulik, #plasma, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200120/5dd4a6cd/attachment-0001.html>
More information about the Plasma-devel
mailing list