D26784: KCM KDED: Add immutability and fix default, reset, apply buttons

[Kevin Ottens]

ervin added inline comments.

INLINE COMMENTS

> kcmkded.cpp:234
>          const bool autoloadEnabled = idx.data(ModulesModel::AutoloadEnabledRole).toBool();
> +        m_model->setData(idx, autoloadEnabled,ModulesModel::AutoloadEnabledSavedRole);
>          KConfigGroup cg(&kdedrc, QStringLiteral("Module-%1").arg(moduleName));

Missing space after ,

> modulesmodel.cpp:85
>  
> +bool ModulesModel::representsDefault() const {
> +    bool isDefault = true;

Curly brace should be on its own line

> modulesmodel.cpp:99
> +
> +bool ModulesModel::needsSave() const {
> +    bool save = false;

Curly brace should be on its own line

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26784

To: bport, ervin, crossi, meven, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200120/6be22074/attachment-0001.html>