D26705: KCM/Component Revamp Terminal Emulator UI

[Kevin Ottens]

ervin added inline comments.

INLINE COMMENTS

> componentchooserterminal.cpp:46
>  
> -void CfgTerminalEmulator::configChanged()
> -{
> -	emit changed(true);
> +void CfgTerminalEmulator::selectTerminalEmulator(int index) {
> +    Q_UNUSED(index)

Curly brace should be on its own line

> componentchooserterminal.cpp:49
> +
> +    if (index == terminalCombo->count() -1) {
> +        selectTerminalApp();

Missing space after -

REPOSITORY
  R119 Plasma Desktop

BRANCH
  terminal-config

REVISION DETAIL
  https://phabricator.kde.org/D26705

To: meven, #plasma, ervin, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200120/24f5fe33/attachment-0001.html>