D26770: [App Style KCM] Hide preview buttons, if previewers are not found

Mikhail Zolotukhin noreply at phabricator.kde.org
Sun Jan 19 17:15:05 GMT 2020


gikari created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gikari requested review of this revision.

REVISION SUMMARY
  BUG: 416343
  FIXED-IN: 5.18.0

TEST PLAN
  1. Open GTK page of Application Style KCM, the preview buttons should be present
  2. Delete `usr/lib/libexec/gtk_preview` file or rename it to something else
  3. Reopen GTK page of KCM - the GTK2 preview button should disappear
  4. Delete `usr/lib/libexec/gtk3_preview` file or rename it to something else
  5. Reopen GTK page of KCM - the GTK3 preview button should disappear too
  6. Bring back the deleted/renamed files
  7. Reopen KCM, the buttons should be present

REPOSITORY
  R119 Plasma Desktop

BRANCH
  hide-preview-buttons

REVISION DETAIL
  https://phabricator.kde.org/D26770

AFFECTED FILES
  kcms/style/CMakeLists.txt
  kcms/style/gtkpage.cpp
  kcms/style/gtkpage.h
  kcms/style/package/contents/ui/GtkStylePage.qml

To: gikari
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200119/2483e05e/attachment.html>


More information about the Plasma-devel mailing list