D26765: Correctly save shortcuts of new Items
David Redondo
noreply at phabricator.kde.org
Sun Jan 19 13:35:38 GMT 2020
davidre created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.
REVISION SUMMARY
When saving first all changes are saved before updating syscoca. This lead to a
crash because serviceByStorageId failed. We can just change the API to directly to
take KService::Ptr's.
BUG: 415699
TEST PLAN
Correctly created a new item and set a shortcut for it
REPOSITORY
R103 KMenu Editor
BRANCH
newitems (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D26765
AFFECTED FILES
globalaccel.cpp
globalaccel.h
kconf_update/globalaccel.cpp
menuinfo.cpp
To: davidre
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200119/5f3ff9de/attachment.html>
More information about the Plasma-devel
mailing list