D26739: [applets/Task Manager] Refine tooltip highlight effect
Nathaniel Graham
noreply at phabricator.kde.org
Fri Jan 17 21:06:04 GMT 2020
ngraham created this revision.
ngraham added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.
REVISION SUMMARY
This patch implements the following visual tweaks:
- Draws the highlight effect on top so that it tints the content
- Indents the media controls by `units.smallSpacing` to match the window thumbnail
Now the boundaries of the highlight effect don't get overlapped by the content inside,
and the highlight effect is more visible for tooltips where the thumbnail or album art
takes up most of the space.
BUG: 416390
FIXED-IN: 5.18.0
TEST PLAN
F7888903: After, with album art.png <https://phabricator.kde.org/F7888903>
F7888902: After, thumbnail with no media controls.png <https://phabricator.kde.org/F7888902>
F7888901: After, no album art and unminimized.png <https://phabricator.kde.org/F7888901>
F7888900: After, no album art and minimized.png <https://phabricator.kde.org/F7888900>
REPOSITORY
R119 Plasma Desktop
BRANCH
refine-tooltip-highlight-effects (branched from Plasma/5.18)
REVISION DETAIL
https://phabricator.kde.org/D26739
AFFECTED FILES
applets/taskmanager/package/contents/ui/ToolTipInstance.qml
To: ngraham, #plasma, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200117/aae65d7f/attachment.html>
More information about the Plasma-devel
mailing list