D26717: [App Style KCM] Port GTK GHNS dialogs from exec()
Mikhail Zolotukhin
noreply at phabricator.kde.org
Thu Jan 16 20:45:52 GMT 2020
gikari created this revision.
gikari added a reviewer: broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gikari requested review of this revision.
REVISION SUMMARY
Move away from using QDialog::exec() due to using nested event loop.
Also make knsrc files use better names.
TEST PLAN
Test dialogs for GTK themes installation.
REPOSITORY
R119 Plasma Desktop
BRANCH
change-exec (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D26717
AFFECTED FILES
kcms/style/CMakeLists.txt
kcms/style/cgcgtk3.knsrc
kcms/style/cgctheme.knsrc
kcms/style/gtk2_themes.knsrc
kcms/style/gtk3_themes.knsrc
kcms/style/gtkpage.cpp
kcms/style/gtkpage.h
kcms/style/gtkthemesmodel.h
kcms/style/package/contents/ui/GtkStylePage.qml
To: gikari, broulik
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200116/7c305ce1/attachment.html>
More information about the Plasma-devel
mailing list