D26655: show a thin separator between view and scrollbar

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  In D26655#595314 <https://phabricator.kde.org/D26655#595314>, @mart wrote:
  
  > In D26655#595102 <https://phabricator.kde.org/D26655#595102>, @ndavis wrote:
  >
  > > I noticed that when hovering on the scrollbar border, while the view area is not focused, the scrollbar handle is light gray (Breeze Dark, dark gray for Breeze) instead of blue. Moving the mouse just slightly more to the right turns the scrollbar handle blue.
  >
  >
  > That's the difference between thesubControlRect of the handle (that has been moved by one pixel to the right for the line) and the rectangle of the entire scrollbar.
  >
  > to change this and have the handle always hitting, the subcontrolrects should stay the same and just paint the handle moved by one pixeltough the subcontrol rects not moving.
  >  either is good, probably the latter approach looks a bit dirtier in the code but if you think is better from a design pov, it can be done
  
  
  Yeah. I think one has to go this second way, to avoid the 1 pixel color flicker noted by Noah: scrollbar hover without handle hover. 
  Right now the scrollbar hit area includes the separator, while the handle does not. 
  Agreed that the code will look slightly less intuitive but so be it.
  
  Hugo

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26655

To: mart, #plasma, #breeze, #vdg, ngraham, hpereiradacosta
Cc: ndavis, ahiemstra, hpereiradacosta, mthw, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200116/3e9b2c3d/attachment.html>