D26570: Improve Plasma user feedback introspection
Aleix Pol Gonzalez
noreply at phabricator.kde.org
Wed Jan 15 17:58:38 GMT 2020
apol added inline comments.
INLINE COMMENTS
> davidedmundson wrote in feedback.cpp:41
> where do you use this?
It's used by `std::sort(m_feedbackSources.begin(), m_feedbackSources.end()...`
> davidedmundson wrote in feedback.cpp:109
> This doesn't look right.
>
> With 2 async processes, the second one to come in will replace the first?
No, we're using m_uses, because we need the proper integration. That's why we keep both.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D26570
To: apol, #plasma
Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200115/042ae62f/attachment.html>
More information about the Plasma-devel
mailing list