D26570: Improve Plasma user feedback introspection

[David Edmundson]

davidedmundson added a comment.


  Quite a clever solution. I like the general idea.
  
  One major comment at the bottom, rest aren't important.

INLINE COMMENTS

> feedback.cpp:41
> +
> +inline void swap(QJsonValueRef v1, QJsonValueRef v2)
> +{

where do you use this?

> feedback.cpp:109
> +    p->deleteLater();
> +    m_feedbackSources = {};
> +    for (auto it = m_uses.constBegin(), itEnd = m_uses.constEnd(); it != itEnd; ++it) {

This doesn't look right.

With 2 async processes, the second one to come in will replace the first?

> main.qml:90
>  
> -                Component.onCompleted: {
> +                value: {
>                      var idx = findIndex(modeOptions, kcm.plasmaFeedbackLevel)

unrelated to this patch.

> main.qml:144
> +                                        delegate: Image {
> +                                            source: "image://icon/" + modelData
> +                                        }

AFAIK we're deprecating this.

Use of Kirigami.Icon would be preferred

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26570

To: apol, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200115/c9cd4907/attachment-0001.html>