D26680: [kcms/feedback] Implement setRepresentsDefaults
Méven Car
noreply at phabricator.kde.org
Wed Jan 15 08:31:08 GMT 2020
meven added inline comments.
INLINE COMMENTS
> feedback.cpp:43
>
> connect(this, &Feedback::plasmaFeedbackLevelChanged, this, [this](){
> setNeedsSave(true);
nitpick, You could move this to `Feedback::setPlasmaFeedbackLevel` as well.
1 saves a connect,
2 make setRepresesentsDefault and setNeedsSave close in the file
REPOSITORY
R120 Plasma Workspace
BRANCH
origin-master (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D26680
To: davidedmundson, #plasma, ngraham
Cc: meven, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200115/c264474b/attachment.html>
More information about the Plasma-devel
mailing list