D26676: [applets/calculator] Use Qt's in-built number formatting

David Edmundson noreply at phabricator.kde.org
Tue Jan 14 23:03:58 GMT 2020


davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Gets rid of a load of code. 
  Correctly handles floating point issues.
  Results are correct.
  
  Potentially this inadvertedly introduces a behaviour change
  of including group separators depending on locale. 
  Is this a a good feature?
  
  BUG: 410988

TEST PLAN
  62 * 1.3 = 80.6
  
  100000000 * 5000000 = 5e+17
  (with whatever the right number of zeroes is)
  
  42 * 1.33333 = 6.6666665

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26676

AFFECTED FILES
  applets/calculator/package/contents/ui/calculator.qml

To: davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200114/d9dda739/attachment.html>


More information about the Plasma-devel mailing list