D26583: [Application Style] Add GTK Application Style Page

[Mikhail Zolotukhin]

gikari added inline comments.

INLINE COMMENTS

> davidedmundson wrote in gtkthemesmodel.cpp:107
> this needs to be
> 
> if (parent.isValid()) {
> return m_themesList.count();
> }
> return 0;
> 
> Otherwise your're saying every item has children with N rows, which have children with N rows forever.

Did you mean

  if (parent.isValid()) {
      return 0;
  }
  return m_themesList.count();

?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  gtk-style-page

REVISION DETAIL
  https://phabricator.kde.org/D26583

To: gikari, #vdg, broulik, #plasma, ngraham
Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200114/397ebed1/attachment-0001.html>