D26656: Use QQC2 Page as base for Kirigami Page
Arjen Hiemstra
noreply at phabricator.kde.org
Tue Jan 14 11:03:57 GMT 2020
ahiemstra created this revision.
ahiemstra added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.
REVISION SUMMARY
Instead of using Templates directly, use QQC2 page as base class for
Kirigami's Page. With Qt 5.14 something in the typing has become more
strict, so assigning Kirigami's Page to a property using QQC2 Page as
type fails.
This fixes Kirigami Gallery for me.
TEST PLAN
Kirigami Gallery works again.
REPOSITORY
R169 Kirigami
BRANCH
page-is-not-page
REVISION DETAIL
https://phabricator.kde.org/D26656
AFFECTED FILES
src/controls/Page.qml
To: ahiemstra, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200114/58934a3d/attachment.html>
More information about the Plasma-devel
mailing list