D26586: [SystemTray] Rework system tray settings

[Konrad Materka]

kmaterka marked 2 inline comments as done.
kmaterka added a comment.


  Anything else to change/fix? When is the code freeze, this Friday?

INLINE COMMENTS

> kmaterka wrote in ConfigEntries.qml:114
> Yes, I don't like this neither. It is a workaround for a problem in Kirigami.AbstractListItem. It automatically calculates paddings when scrollbars are detected:
> kirigami/src/controls/templates/AbstractListItem.qml$144-165 <https://phabricator.kde.org/source/kirigami/browse/master/src/controls/templates/AbstractListItem.qml$144-165>
> It checks if view has scrollbars attached: `internal.view.T2.ScrollBar.vertical`.
> I checked other projects (Discover), Kirigami.AbstractListItem is used inside ScrollablePage, which add scrollbars directly to the ListView (defined in custom templates/private/ScrollView.qml <https://phabricator.kde.org/source/kirigami/browse/master/src/controls/templates/private/ScrollView.qml$75>.
> 
> I use plain QQC2.ScrollView, which attaches scrollbars to itself, not ListView. As a result scrollbars are not detected and padding is not added.
> 
> I don't know how to fix that correctly without duplicating a code in ConfigEntries.qml. I can override leftPadding and rightPadding, but I prefer to use original logic (in case it changes in the future). Can you advice?

I replaced this hack with explicit paddings settings

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26586

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham
Cc: mart, meven, nicolasfella, plasma-devel, ngraham, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200114/910beb00/attachment.html>