D26639: Make checkboxes/radiobuttons use Window Background in windows and View Backround in lists

[Hugo Pereira Da Costa]

hpereiradacosta accepted this revision.
hpereiradacosta added a comment.
This revision is now accepted and ready to land.


  In D26639#593537 <https://phabricator.kde.org/D26639#593537>, @ndavis wrote:
  
  > In D26572#593511 <https://phabricator.kde.org/D26572#593511>, @hpereiradacosta wrote:
  >
  > > > Otherwise, it should be Window Background. Doing it that way would preserve the original look in most cases.
  > >
  > > This would lead to some regression (I think) for unchecked checkboxes in lists. (because of window background being used).
  >
  >
  > This doesn't seem to have any visual regressions like that.
  
  
  That works yes (since you test for parent item view). 
  Also yes, feel free to remove the now unused isItemSelected.
  Thanks for the patch !

REPOSITORY
  R31 Breeze

BRANCH
  checkbox-radiobutton (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26639

To: ndavis, #vdg, #breeze, hpereiradacosta, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200113/fef366a7/attachment.html>