D26530: ScrollView: Do not overlay scrollbars over contents

[Marco Martin]

mart added a comment.


  ok for it, provided it still has overlay scrollbars on tablet mode

INLINE COMMENTS

> ScrollView.qml:47
> +
> +    readonly property bool _backgroundVisible: background && background.visible
> +    readonly property real _verticalScrollBarWidth: ScrollBar.vertical.visible ? ScrollBar.vertical.width : 0

those properties should be top level, (even starting with _ )
there is stuff inside data: already, it can be put inside there

> ScrollView.qml:48
> +    readonly property bool _backgroundVisible: background && background.visible
> +    readonly property real _verticalScrollBarWidth: ScrollBar.vertical.visible ? ScrollBar.vertical.width : 0
> +    readonly property real _horizontalScrollBarWidth: ScrollBar.horizontal.visible ? ScrollBar.horizontal.width : 0

it should also have the condition: !Kirigami.Settings.tabletMode

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D26530

To: ahiemstra, #plasma, #goal_consistency, mart
Cc: kmaterka, mart, ndavis, IlyaBizyaev, ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200113/58690107/attachment.html>