D26632: Fix warning on ScrollablePage
Aleix Pol Gonzalez
noreply at phabricator.kde.org
Mon Jan 13 15:49:12 GMT 2020
apol created this revision.
apol added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.
REVISION SUMMARY
At the moment we'll be going through all of the children objects and reassigning
the overlay as the parent. This is problematic because some objects won't allow
it, getting things like
ScrollablePage.qml:189: Error: Cannot assign QObject* to Action_QMLTYPE_11*
This patch changes it so only Items are reparented
TEST PLAN
Don't get the warnings anymore
REPOSITORY
R169 Kirigami
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D26632
AFFECTED FILES
src/controls/ScrollablePage.qml
To: apol, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200113/155cb889/attachment.html>
More information about the Plasma-devel
mailing list