D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

[Dan Leinir Turthra Jensen]

leinir added inline comments.

INLINE COMMENTS

> davidedmundson wrote in main.cpp:254
> FWIW, there is an alternative approach that we do in plasma-workspace (shell/containmentconfigview.cpp) for reloading wallpapers types.
> 
> kpackage emits a DBus signal when it performs an action, models can listen for this.
> 
> We had to do that there because the model was quite separated from the UI. 
> But it has the advantage that we pick up external changes (i.e through discover or whatever)

That does sound like something that would be good to look at at a later point in time (it'd make this whole thing vastly more involved, and i'm trying to keep it a bit more simple for now)

> davidedmundson wrote in main.cpp:275
> Does this code still exist? I can't see an equivalent in knewstuff.
> 
> It's especially important on wayland

The new dialog is entirely QtQuick (clicking the NewStuff.Button essentially just calls open() on a QtQuick.Dialogs Dialog, so if doing show on a QtQuick Dialog does the trick, then yes. Otherwise i am... severely uncertain of how that might be solved (though it would be central at least, since the code would be in KNSQuick).

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26544

To: leinir, mart
Cc: bcooksley, davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200113/402df4f9/attachment.html>