D26583: [Application Style] Add GTK Application Style Page
Mikhail Zolotukhin
noreply at phabricator.kde.org
Sat Jan 11 13:34:24 GMT 2020
gikari created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gikari requested review of this revision.
REVISION SUMMARY
The GTK KCM is now moved to Application Style KCM as a sub page. The
functionality is identical to the one, found in GTK KCM, as well for the
bugs :)
The page is only accessible, if the `gtkconfig` kded module is loaded,
because only with the module the configuration can be changed.
Depends on D26261 <https://phabricator.kde.org/D26261>
TEST PLAN
1. Apply D26261 <https://phabricator.kde.org/D26261>
2. **Restart kded5**
3. Open System Settings, go to Application Style KCM
4. The button for GTK Configuration should be present
5. Go to Startup and Shutdown > Background Services, disable `Plasma GTKd`
6. Return to the App Style KCM, the button should disappear
7. Return to the Kded KCM and enable `Plasma GTKd` back
8. Return to the App Style KCM - button is present now
9. Go to subpage
10. Happy (I hope) testing!
REPOSITORY
R119 Plasma Desktop
BRANCH
gtk-style-page
REVISION DETAIL
https://phabricator.kde.org/D26583
AFFECTED FILES
kcms/style/CMakeLists.txt
kcms/style/cgcgtk3.knsrc
kcms/style/cgctheme.knsrc
kcms/style/gtkpage.cpp
kcms/style/gtkpage.h
kcms/style/gtkthemesmodel.cpp
kcms/style/gtkthemesmodel.h
kcms/style/kcmstyle.cpp
kcms/style/kcmstyle.h
kcms/style/package/contents/ui/GtkStylePage.qml
kcms/style/package/contents/ui/main.qml
To: gikari
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200111/34456c3a/attachment.html>
More information about the Plasma-devel
mailing list