D26566: Fix layout for the reviews sheet
Marco Martin
noreply at phabricator.kde.org
Fri Jan 10 17:05:25 GMT 2020
mart created this revision.
mart added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
mart requested review of this revision.
REVISION SUMMARY
- the main contentitem of a sheet should have *always* an explicit implicitWidth
- never use anchors for delegates
TEST PLAN
ireviews sheet works ok now both in desktop and mobile modes
REPOSITORY
R134 Discover Software Store
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D26566
AFFECTED FILES
discover/qml/ReviewDelegate.qml
discover/qml/ReviewsPage.qml
To: mart, #plasma, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200110/73afc144/attachment-0001.html>
More information about the Plasma-devel
mailing list